Implement LittleSet (follow-up on #95)
#107
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This overcomes the issue with Julia v1.6 not supporting replace for tuples and does a better job working around the opaque tuple variant
fingolfin
reviewed
Nov 24, 2024
fingolfin
reviewed
Nov 24, 2024
fingolfin
reviewed
Nov 24, 2024
Tokazama
force-pushed
the
zpc-little-set
branch
from
a46d7e7 to
267cee1
Compare
Julia v1.7+ supports `replace` for tuples so had to manually implement this here. Also removed inference testing for the current approach since it uses a temporary `Vector` to store results. This is probably a sold approach for any frozen set of tuples over 32, but it would be good to optimize for smaller cases in the future.
Tokazama
force-pushed
the
zpc-little-set
branch
from
6cee602 to
d92f266
Compare
Tokazama
force-pushed
the
zpc-little-set
branch
from
618c723 to
66f0308
Compare
Tokazama
force-pushed
the
zpc-little-set
branch
from
9b45ac8 to
7b3c495
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an updated go at #95 thats more feature complete and tests